Skip to content

Commit cb849ba

Browse files
authored
fix(ui5-slider): focus outline fully visible (#2971)
The focus outline was not fully visible among different browsers and mobile devices.
1 parent 553111f commit cb849ba

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

packages/main/src/themes/SliderBase.css

+8-4
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,17 @@
4747
background: var(--_ui5_slider_progress_background);
4848
border-radius: var(--_ui5_slider_progress_border_radius);
4949
height: var(--_ui5_slider_inner_height);
50-
will-change: transform;
5150
position: relative;
51+
outline: none;
5252
}
5353

54-
.ui5-slider-progress:focus {
55-
outline: var(--_ui5_slider_progress_outline);
56-
outline-offset: var(--_ui5_slider_progress_outline_offset);
54+
.ui5-slider-progress:focus::after {
55+
content: '';
56+
position: absolute;
57+
width: 100%;
58+
border: var(--_ui5_slider_progress_outline);
59+
top: var(--_ui5_slider_progress_outline_offset);
60+
height: var(--_ui5_slider_outer_height);
5761
}
5862

5963
.ui5-slider-tickmarks {

packages/main/src/themes/base/SliderBase-parameters.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
--_ui5_slider_progress_container_background: var(--sapField_BorderColor);
44
--_ui5_slider_progress_border: none;
55
--_ui5_slider_inner_height: 0.25rem;
6+
--_ui5_slider_outer_height: 1.6875rem;
67
--_ui5_slider_progress_border_radius: 0.25rem;
78
--_ui5_slider_progress_background: var(--sapActiveColor);
89
--_ui5_slider_handle_height: 1.625rem;
@@ -18,7 +19,7 @@
1819
--_ui5_slider_handle_outline_offset: 0.075rem;
1920
--_ui5_range_slider_handle_hover_background: rgba(var(--sapButton_Background), 0.25);
2021
--_ui5_slider_progress_outline: 0.0625rem dotted var(--sapContent_FocusColor);
21-
--_ui5_slider_progress_outline_offset: 0.525rem;
22+
--_ui5_slider_progress_outline_offset: -0.8125rem;
2223
--_ui5_slider_tickmark_color: #89919a;
2324
--_ui5_slider_tickmark_top: -0.375rem;
2425
--_ui5_slider_disabled_opacity: 0.4;

packages/main/src/themes/base/sizes-parameters.css

+2
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,8 @@
232232
--_ui5_slider_tooltip_height: 1rem;
233233
--_ui5_slider_tooltip_padding: 0.25rem;
234234
--_ui5_slider_tooltip_bottom: 1.825rem;
235+
--_ui5_slider_progress_outline_offset: -0.625rem;
236+
--_ui5_slider_outer_height: 1.3125rem;
235237

236238
/* Table */
237239
--_ui5_load_more_text_height: 2.625rem;

0 commit comments

Comments
 (0)