Skip to content

Commit d045ba2

Browse files
authored
fix(ui5-multi-combobox): n-more popover in readonly fixed (#2394)
FIXES: #2369
1 parent 2194b16 commit d045ba2

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/main/src/MultiComboBox.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -400,10 +400,6 @@ class MultiComboBox extends UI5Element {
400400
}
401401

402402
_showMorePopover() {
403-
if (this.readonly) {
404-
return;
405-
}
406-
407403
this.filterSelected = true;
408404
this._toggleRespPopover();
409405
}
@@ -757,6 +753,10 @@ class MultiComboBox extends UI5Element {
757753
return this.readonly ? "None" : "MultiSelect";
758754
}
759755

756+
get _listItemsType() {
757+
return this.readonly ? "Inactive" : "Active";
758+
}
759+
760760
get hasValueState() {
761761
return this.valueState !== ValueState.None;
762762
}
@@ -816,7 +816,7 @@ class MultiComboBox extends UI5Element {
816816
}
817817

818818
get _tokenizerExpanded() {
819-
return this._rootFocused || this.open;
819+
return (this._rootFocused || this.open) && !this.readonly;
820820
}
821821

822822
get classes() {

packages/main/src/MultiComboBoxPopover.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868

6969
<ui5-list separators="None" mode="MultiSelect" class="ui5-multi-combobox-all-items-list">
7070
{{#each _filteredItems}}
71-
<ui5-li type="Active" ?selected={{this.selected}} data-ui5-token-id="{{this._id}}">{{this.text}}</ui5-li>
71+
<ui5-li type="{{../_listItemsType}}" ?selected={{this.selected}} data-ui5-token-id="{{this._id}}">{{this.text}}</ui5-li>
7272
{{/each}}
7373
</ui5-list>
7474

0 commit comments

Comments
 (0)