Skip to content

Commit d449812

Browse files
authoredApr 23, 2021
fix(ui5-wizard): correct aria-controls value (#3180)
1 parent 655ec49 commit d449812

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

‎packages/fiori/src/Wizard.hbs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div class="ui5-wiz-root" aria-label="{{ariaLabelText}}" role="region">
22
<nav class="ui5-wiz-nav" aria-label="{{navAriaLabelText}}" tabindex="-1">
3-
<div class="ui5-wiz-nav-list" role="list" aria-label="{{listAriaLabelText}}" aria-controls="ui5-wiz-content" >
3+
<div class="ui5-wiz-nav-list" role="list" aria-label="{{listAriaLabelText}}" aria-controls="{{_id}}-wiz-content">
44
{{#each _stepsInHeader}}
55
<ui5-wizard-tab
66
heading="{{heading}}"
@@ -25,7 +25,7 @@
2525
</div>
2626
</nav>
2727

28-
<div class="ui5-wiz-content" @scroll="{{onScroll}}">
28+
<div id="{{_id}}-wiz-content" class="ui5-wiz-content" @scroll="{{onScroll}}">
2929
{{#each _steps}}
3030
<div class="ui5-wiz-content-item"
3131
?hidden="{{disabled}}"

‎packages/fiori/test/specs/Wizard.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe("Wizard general interaction", () => {
3636
"Wizard nav has aria-label set.");
3737
assert.strictEqual(wizList.getAttribute("role"), "list",
3838
"Wizard list has role set..");
39-
assert.strictEqual(wizList.getAttribute("aria-controls"), "ui5-wiz-content",
39+
assert.strictEqual(wizList.getAttribute("aria-controls"), `${wiz.getProperty("_id")}-wiz-content`,
4040
"Wizard list has aria-controls set.");
4141
assert.strictEqual(wizList.getAttribute("aria-label"), wizListText,
4242
"Wizard list has aria-label set.");

0 commit comments

Comments
 (0)
Please sign in to comment.