Skip to content

Commit e899708

Browse files
authored
fix(ui5-dialog): dialog focus trapping works again (#1213)
1 parent 7f30cf3 commit e899708

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/main/src/Dialog.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{>include "./Popup.hbs"}}
22

3-
<span class="ui5-popup-frame">
3+
<span class="ui5-popup-frame" @focusin="{{_onfocusin}}">
44
<span id="{{_id}}-firstfe" tabindex="0"></span>
55
<div style="{{zindex}}" class="ui5-dialog-root-parent {{classes.dialogParent}}">
66
<div tabindex="-1" aria-labelledby="{{headerId}}" role="dialog" aria-modal="true" class="ui5-popup-root ui5-dialog-root">

packages/main/src/Popup.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ class Popup extends UI5Element {
385385
}
386386
}
387387

388-
onfocusin(event) {
388+
_onfocusin(event) {
389389
this.preserveFocus(event, this.getPopupDomRef());
390390
}
391391

0 commit comments

Comments
 (0)