Skip to content

Commit edfe8ca

Browse files
authored
fix(ui5-input): fix value state msg appearance (#2075)
Fixes the height when the value state msg is displayed as standalone popovr and within the suggestions popover FIXES #2070
1 parent bf19767 commit edfe8ca

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

packages/main/src/Input.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -732,7 +732,7 @@ class Input extends UI5Element {
732732
}
733733

734734
/**
735-
* Checks if the popover is open.
735+
* Checks if the value state popover is open.
736736
* @returns {Boolean} true if the popover is open, false otherwise
737737
* @public
738738
*/
@@ -1034,6 +1034,7 @@ class Input extends UI5Element {
10341034
return {
10351035
popoverValueState: {
10361036
"ui5-valuestatemessage-root": true,
1037+
"ui5-responsive-popover-header": !this.isOpen(),
10371038
"ui5-valuestatemessage--success": this.valueState === ValueState.Success,
10381039
"ui5-valuestatemessage--error": this.valueState === ValueState.Error,
10391040
"ui5-valuestatemessage--warning": this.valueState === ValueState.Warning,

packages/main/src/InputPopover.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
class="ui5-valuestatemessage-popover"
7373
placement-type="Bottom"
7474
>
75-
<div slot="header" class="ui5-responsive-popover-header {{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
75+
<div slot="header" class="{{classes.popoverValueState}}" style="{{styles.popoverHeader}}">
7676
{{> valueStateMessage}}
7777
</div>
7878
</ui5-popover>

packages/main/src/themes/ResponsivePopoverCommon.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
.ui5-responsive-popover-header .row {
124124
box-sizing: border-box;
125125
padding: 0.25rem 1rem;
126-
height: 2.5rem;
126+
min-height: 2.5rem;
127127
display: flex;
128128
justify-content: center;
129129
align-items: center;

0 commit comments

Comments
 (0)