Skip to content

Commit fb0b24c

Browse files
authoredNov 30, 2020
feat(ui5-flexible-column-layout): add start/mid/endColumnAccessibleName properties (#2483)
1 parent b5c4a92 commit fb0b24c

File tree

2 files changed

+45
-4
lines changed

2 files changed

+45
-4
lines changed
 

‎packages/fiori/src/FlexibleColumnLayout.js

+39-3
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,42 @@ const metadata = {
8282
type: Boolean,
8383
},
8484

85+
/**
86+
* Defines the accessibility name for the <code>startColumn</code> region.
87+
*
88+
* @type {string}
89+
* @defaultvalue ""
90+
* @public
91+
* @since 1.0.0-rc.11
92+
*/
93+
startColumnAccessibleName: {
94+
type: String,
95+
},
96+
97+
/**
98+
* Defines the accessibility name for the <code>midColumn</code> region.
99+
*
100+
* @type {string}
101+
* @defaultvalue ""
102+
* @public
103+
* @since 1.0.0-rc.11
104+
*/
105+
midColumnAccessibleName: {
106+
type: String,
107+
},
108+
109+
/**
110+
* Defines the accessibility name for the <code>endColumn</code> region.
111+
*
112+
* @type {string}
113+
* @defaultvalue ""
114+
* @public
115+
* @since 1.0.0-rc.11
116+
*/
117+
endColumnAccessibleName: {
118+
type: String,
119+
},
120+
85121
/**
86122
* Defines the component width in px.
87123
*
@@ -620,15 +656,15 @@ class FlexibleColumnLayout extends UI5Element {
620656
}
621657

622658
get accStartColumnText() {
623-
return this.i18nBundle.getText(FCL_START_COLUMN_TXT);
659+
return this.startColumnAccessibleName || this.i18nBundle.getText(FCL_START_COLUMN_TXT);
624660
}
625661

626662
get accMiddleColumnText() {
627-
return this.i18nBundle.getText(FCL_MIDDLE_COLUMN_TXT);
663+
return this.midColumnAccessibleName || this.i18nBundle.getText(FCL_MIDDLE_COLUMN_TXT);
628664
}
629665

630666
get accEndColumnText() {
631-
return this.i18nBundle.getText(FCL_END_COLUMN_TXT);
667+
return this.endColumnAccessibleName || this.i18nBundle.getText(FCL_END_COLUMN_TXT);
632668
}
633669

634670
get _effectiveLayoutsByMedia() {

‎packages/fiori/test/pages/FCLApp.html

+6-1
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,12 @@
177177
</ui5-shellbar>
178178

179179
<!--- FLEXIBLE COLUMN LAYOUT -->
180-
<ui5-flexible-column-layout id="fcl">
180+
<ui5-flexible-column-layout
181+
id="fcl"
182+
start-column-accessible-name="Companies list"
183+
mid-column-accessible-name="Products List"
184+
end-column-accessible-name="Product Details"
185+
>
181186
<div class="column" id="startColumn" slot="startColumn">
182187
<ui5-busyindicator id="startBusy">
183188
<div class="ui5-message-page">

0 commit comments

Comments
 (0)
Please sign in to comment.