Skip to content

Commit fe76278

Browse files
authored
fix(ui5-list): remove busy indicator dom (#2712)
Follow up of #2684 where the placement of the busy has been fixed. With this change we make sure the busy ind DOM is not even rendered when the List is not busy. And, aims to fix the issue with components such as the ComboBox, Select and Input, that uses the List internally, would display additional space after the last list item.
1 parent 1f07d50 commit fe76278

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

packages/main/src/List.hbs

+5-3
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@
4747
{{/if}}
4848
</div>
4949

50-
<div class="ui5-list-busy-row">
51-
<ui5-busyindicator ?active="{{busy}}" size="Medium" class="ui5-list-busy-ind"></ui5-busyindicator>
52-
</div>
50+
{{#if busy}}
51+
<div class="ui5-list-busy-row">
52+
<ui5-busyindicator active size="Medium" class="ui5-list-busy-ind"></ui5-busyindicator>
53+
</div>
54+
{{/if}}
5355
</div>

packages/main/test/specs/List.spec.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ describe("List Tests", () => {
77
});
88

99
it("List is rendered", () => {
10-
const list = browser.$("ui5-list").shadow$(".ui5-list-root");
10+
const list = browser.$("#infiniteScrollEx").shadow$(".ui5-list-root");
11+
const busyInd = browser.$("#infiniteScrollEx").shadow$(".ui5-list-busy-row");
1112

12-
assert.ok(list, "List is rendered");
13+
assert.ok(list.isExisting(), "List is rendered");
14+
assert.notOk(busyInd.isExisting(), "Busy indicator is not rendered, when List is not busy");
1315
});
1416

1517
it("itemPress and selectionChange events are fired in Single selection", () => {

0 commit comments

Comments
 (0)