Skip to content

Commit ff247f0

Browse files
authored
fix(ui5-li-notification-group): align priority icon (#2584)
Now the priority icon of the NotificationListGroupItem and the children items are aligned.
1 parent 5a85687 commit ff247f0

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

packages/fiori/src/NotificationListItem.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
</div>
5050

5151
<div class="ui5-nli-content {{classes.content}}">
52-
<div class="ui5-nli-heading">
52+
<div class="ui5-nli-heading-wrapper">
5353
{{#if hasPriority}}
5454
<ui5-icon
5555
class="ui5-prio-icon ui5-prio-icon--{{priorityIcon}}"

packages/fiori/src/NotificationListItem.js

+4
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,10 @@ const metadata = {
8181
*
8282
* <br><br>
8383
* <b>Note:</b> Consider using the <code>ui5-avatar</code> to display icons, initials or images.
84+
* <br>
85+
* <b>Note:</b>In order to be complaint with the UX guidlines and for best experience,
86+
* we recommend using avatars with 2rem X 2rem in size (32px X 32px). In case you are using the <code>ui5-avatar</code>
87+
* you can set its <code>size</code><code> property to <code>XS</code> to get the required size - <code><ui5-avatar size="XS"></code>.
8488
*
8589
* @type {HTMLElement}
8690
* @slot

packages/fiori/src/themes/NotificationListGroupItem.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
}
3333

3434
.ui5-nli-group-toggle-btn {
35-
margin-right: 1rem;
35+
margin-right: 0.75rem;
3636
cursor: pointer;
3737
}
3838

packages/fiori/src/themes/NotificationListItem.css

+5
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,11 @@
6565
box-sizing: border-box;
6666
}
6767

68+
.ui5-nli-heading-wrapper {
69+
display: flex;
70+
flex-direction: row;
71+
}
72+
6873
.ui5-nli-heading {
6974
display: flex;
7075
margin-bottom: 0.25rem;

0 commit comments

Comments
 (0)