feat(ui5-datepicker): implementing min and max date limits #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents into datepicker-min-max-date-implementation
vladitasev
reviewed
Jan 31, 2020
packages/main/src/Calendar.js
Outdated
| if (this._minDate) { | ||
| this.timestamp = this._minDate / 1000; | ||
| } else { | ||
| this.timestamp = (new Date(-62135596800000)).getTime() / 1000; |
There was a problem hiding this comment.
Magic number. Please use a constant that explains what this is
| } | ||
|
|
||
| event.preventDefault(); | ||
|
|
||
| await RenderScheduler.whenFinished(); |
There was a problem hiding this comment.
This was meant to be "unofficial" - for the tests only. I'm fine for the moment, but we need to provide a public function for the same.
@pskelin
packages/main/src/Calendar.js
Outdated
| */ | ||
| minDate: { | ||
| type: String, | ||
| defaultValue: undefined, |
There was a problem hiding this comment.
Is it necessary to set "undefined" here? Isn't it undefined by default (or is it empty string)?
There was a problem hiding this comment.
It's an empty string, but still a falsy value so it can be removed, thanks.
packages/main/src/Calendar.js
Outdated
| */ | ||
| maxDate: { | ||
| type: String, | ||
| defaultValue: undefined, |
vladitasev
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team, can you please review this PR.
Regards,
Tsanislav