-
Notifications
You must be signed in to change notification settings - Fork 274
refactor: propagate compact size when ui5-content-density-compact class is set #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort!
One comment:
The size params should be declared 3 times:
:root {default/cozy} - in place
.compact{} - in place
.cozy {} - this is one is missing (when someone configures compact, but want part in cozy)
BREAKING CHANGE: set/get for compact size is removed, use CSS class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the commit message a little bit (use the public class name ui5-...),
and maybe describe the new stuff in section "Content Density" like "Theme" and the rest in the Configuration.md:
- add few words about Content Density (that it defines the sizes, paddings, margins of components)
- mention that by default all components are "Cozy"
- how to set "Compact" and that in Compact the mertics are smaller/ decreased.
BREAKING CHANGE: set/get for compact size is removed, use CSS class ui5-content-density-compact as a replacement. |
No description provided.