Skip to content

refactor: propagate compact size when ui5-content-density-compact class is set #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 17, 2020

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Jan 13, 2020

No description provided.

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort!

One comment:
The size params should be declared 3 times:
:root {default/cozy} - in place
.compact{} - in place
.cozy {} - this is one is missing (when someone configures compact, but want part in cozy)

@MapTo0
Copy link
Member Author

MapTo0 commented Jan 16, 2020

BREAKING CHANGE: set/get for compact size is removed, use CSS class ui5-content-density-compact as a replacement.

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the commit message a little bit (use the public class name ui5-...),
and maybe describe the new stuff in section "Content Density" like "Theme" and the rest in the Configuration.md:

  • add few words about Content Density (that it defines the sizes, paddings, margins of components)
  • mention that by default all components are "Cozy"
  • how to set "Compact" and that in Compact the mertics are smaller/ decreased.

@MapTo0 MapTo0 changed the title refactor: propagate compact size when sapUiCompactSize class is set refactor: propagate compact size when ui5-content-density-compact class is set Jan 16, 2020
@MapTo0
Copy link
Member Author

MapTo0 commented Jan 16, 2020

  • add a global classes ui5-content-density-compact, sapUiSizeCompact(private) which redefine all COSY variables with COMPACT values
  • adopt all components
  • remove compact setting from Configuration
  • update documentation for compact / cosy setting
  • remove content density related modules

BREAKING CHANGE: set/get for compact size is removed, use CSS class ui5-content-density-compact as a replacement.

ilhan007
ilhan007 previously approved these changes Jan 17, 2020
@MapTo0 MapTo0 merged commit 2db62ba into master Jan 17, 2020
@MapTo0 MapTo0 deleted the cosy-compact-refactoring branch January 17, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants