Skip to content

Ui5 Select #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camilo2312 opened this issue Apr 23, 2020 · 5 comments
Closed

Ui5 Select #1517

camilo2312 opened this issue Apr 23, 2020 · 5 comments
Assignees

Comments

@camilo2312
Copy link

Hello everyone

The use of inputs, text area, DatePicker works properly my Reactive Forms, but the ui-select and checbox do not, since I try to capture the valueChanges of my reactive forms and it does not work

The documentation tells me to import the following import '@ ui5 / webcomponents / dist / features / InputElementsFormSupport.js';
I do it but it still doesn't work

image

image

I need to import something or I can't capture the values ​​of my select or checkbox that way

Thank you very much for the help

@fifoosid
Copy link
Contributor

The problem is that these two controls are not yet implemented to support two way data binding in Angular.

PS: In order to use any UI5 Web Component with reactive forms, you don't need to import @ui5/webcomponents/dist/features/InputElementsFormSupport.js;. This module is used only for native HTML forms.

@camilo2312
Copy link
Author

Ok, thanks a lot for the help

@fifoosid
Copy link
Contributor

Will implement them as soon as possible

@fifoosid
Copy link
Contributor

fifoosid commented May 8, 2020

Hi @camilo2312,

As you can see the two way data binding for the select is implemented.

Moreover, a quick update with regards to the checkbox: the component currently supports two way data binding with one bug: if the initial state of the checkbox is checked, it won't be applied. In the latest PR I have proposed a solution, but we are going to discus it internally before we merge it.

@fifoosid
Copy link
Contributor

Now after both PR are merged I am closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants