feat(ui5-shellbar): implement accessibility spec #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added role "baner" and aria-label to the root element
vladitasev
requested changes
Apr 28, 2020
elenastoyanovaa
requested changes
Apr 28, 2020
vladitasev
requested changes
Apr 29, 2020
|
|
||
| #XACT: ARIA announcement for the logo button | ||
| SHELLBAR_LABEL = Logo |
There was a problem hiding this comment.
Why label and then logo. The two texts seem the same
There was a problem hiding this comment.
Forgot to change the value of parameter. It should be Shell Bar and it will be used as value for aria-label attribute of the Shell Bar,
| } | ||
|
|
||
| get menuBtnHasPopup() { | ||
| return this.hasMenuItems ? true : undefined; |
There was a problem hiding this comment.
"true" seems more appropriate, but if it works this way it's ok
There was a problem hiding this comment.
It will be cast to string in when it is used in hbs
elenastoyanovaa
previously approved these changes
Apr 30, 2020
vladitasev
requested changes
May 4, 2020
vladitasev
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented accessibility spec of the ShellBar. In addition some minor issues are fixed:
#1289