feat(ui5-combobox): implement accessibility spec #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested changes
Apr 28, 2020
packages/main/src/ComboBox.js
Outdated
| @@ -490,6 +493,32 @@ class ComboBox extends UI5Element { | |||
| return !this.readonly; | |||
| } | |||
|
|
|||
| get accInfo() { | |||
| return { | |||
| "role": "combobox", | |||
There was a problem hiding this comment.
Are these overwritten from somewhere (maybe multicombobox?) If yes, it's fine, if not -please hardcode them in the template. No need for variable parts for static content.
| @@ -2,6 +2,7 @@ | |||
| no-arrow | |||
| content-only-on-desktop | |||
| _disable-initial-focus | |||
| id="{{_id}}-responsive-popover" | |||
There was a problem hiding this comment.
This is in a separate shadow DOM tree, won't work. You can't reference it from within the shadow tree of the main component
There was a problem hiding this comment.
You are right. We will remove the aria-controls
vladitasev
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES:#1278