feat(ui5-table): allow for custom styling #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user has no control over size and positioning for
ui5-table-column,ui5-table-rowandui5-table-cell.This change exposes shadow parts that make it possible to control these settings.
Additionally, the Table Column must be one element only in order for the positioning to work, so the nested
divis removed.Important: exposing these shadow parts to a large extend binds us to using
th,trandtdas people will start setting CSS properties that work on their respectivedisplaymodes, and wouldn't work ondiv, if we change it down the road.closes: #1626