Skip to content

Allow third parties to import our .hbs files and override the hooks #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladitasev opened this issue Jun 23, 2020 · 0 comments · Fixed by #1860
Closed

Allow third parties to import our .hbs files and override the hooks #1859

vladitasev opened this issue Jun 23, 2020 · 0 comments · Fixed by #1860
Assignees

Comments

@vladitasev
Copy link
Contributor

Currently we have several .hbs files with inline partials, which can be overridden by other components, thus providing hooks.

However, this works only for components in our own packages. Not for third parties for 2 reasons:

  • We don't ship the src/ directory, so no .hbs files at all in node_modules/
  • We can't import in .hbs with mode modules resolution (although a full path can work)

Ideally people could do the following:

In MyPopup.hbs

{{>include "@ui5/webcomponents/src/Popup.hbs"}}

and then override the hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant