Skip to content

fix(ui5-textarea): announce custom valueStateMessage #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2020
Merged

fix(ui5-textarea): announce custom valueStateMessage #2122

merged 2 commits into from
Aug 19, 2020

Conversation

ilhan007
Copy link
Member

FIXES #2106

@ilhan007 ilhan007 requested a review from fifoosid August 19, 2020 10:58
@ilhan007 ilhan007 requested a review from vladitasev August 19, 2020 11:00
@ilhan007 ilhan007 mentioned this pull request Aug 19, 2020
Closed
vladitasev
vladitasev approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value state state/value state message functionality is repeated for many components, maybe we could extract the common logic to some single place, but for now, maybe when all are ready and we can assess how common the patterns are

@ilhan007
Copy link
Member Author

the value state state/value state message functionality is repeated for many components, maybe we could extract the common logic to some single place, but for now, maybe when all are ready and we can assess how common the patterns are

Indeed, for now it is almost the same everywhere with slight differences in the condition when it should appear.

@ilhan007 ilhan007 merged commit 4d27065 into master Aug 19, 2020
@ilhan007 ilhan007 deleted the fix-textarea-vsm-reading branch August 19, 2020 11:33
ilhan007 added a commit that referenced this pull request Aug 20, 2020
@ilhan007
fix(ui5-textarea): announce custom valueStateMessage (#2122)
7dfd0e0 
FIXES #2106
ilhan007 added a commit that referenced this pull request Oct 17, 2020
@ilhan007
fix(ui5-textarea): announce custom valueStateMessage (#2122)
5c2ea1b 
FIXES #2106
ilhan007 added a commit that referenced this pull request Nov 11, 2020
@ilhan007
fix(ui5-textarea): announce custom valueStateMessage (#2122)
3a3c52f 
FIXES #2106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-input: [a11y] customized valueStateMessage from slot is not read correctly
2 participants
@ilhan007 @vladitasev