Skip to content

ui5-daterange-picker: allow first and last day to be the same #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcusNotheis opened this issue Aug 26, 2020 · 0 comments · Fixed by #2157
Closed

ui5-daterange-picker: allow first and last day to be the same #2149

MarcusNotheis opened this issue Aug 26, 2020 · 0 comments · Fixed by #2157
Assignees
Milestone

Comments

@MarcusNotheis
Copy link
Collaborator

MarcusNotheis commented Aug 26, 2020

Describe the bug
We have a scenario where we want to offer the user the possibility to create events. We don't know upfront whether the user wants to create a single-day event or a multi-day event. Therefore it would be beneficial if the DateRangerPicker would we able to provide also a one day selection. (e.g. by clicking the same day twice). I know that there is a DatePicker for that use case but in my opinion the user shouldn't decide whether a DatePicker or a DateRangePicker should be render (e.g. via a Multi Day Event switch.)

To reproduce
Steps to reproduce the behavior:

  1. Open https://sap.github.io/ui5-webcomponents/playground/components/DateRangePicker/
  2. Open the first date range picker and select a date by clicking it twice.
  3. The popover now closes and displays the selected value, but onChange isn't fired
  4. If you now reopen the DateRangePicker, you are immediately in the selection part of selecting a second date which is confusing to me.

Expected behavior
I would expect that selecting a single date by clicking it twice would select that date as firstDateValue and lastDateValue.

Screenshots
Screen-Recording-2020-08-26-at-10 53 56

Context

  • UI5 Web Components version: 1.0.0-rc.8

Affected components (if known)
ui5-daterange-picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants