Skip to content

ui5-datepicker: does not handle some timezones and DST correctly #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lukas742 opened this issue Sep 9, 2020 · 2 comments · Fixed by #2209
Closed

ui5-datepicker: does not handle some timezones and DST correctly #2202

Lukas742 opened this issue Sep 9, 2020 · 2 comments · Fixed by #2209
Assignees
@tsanislavgatev
Milestone
1.0.0-rc.9

Comments

@Lukas742
Copy link
Collaborator

Lukas742 commented Sep 9, 2020 •
edited
Loading

Describe the bug
The Datepicker selects the wrong year in some timezones.

To reproduce

  1. Set your local timezone to PDT.
  2. Go to https://sap.github.io/ui5-webcomponents/playground/components/DatePicker/
  3. Inside the first Datepicker, type: 01.01.2020
  4. The Datepicker has selected the 01.01.2019 instead of 01.01.2020.

Screenshot 2020-09-09 at 06 06 10

For other timezones like CEST it is working as expected.
Screenshot 2020-09-09 at 15 10 06

Expected behavior
The Datepicker should select the correct time in all timezones

Affected components (if known)
ui5-datepicker

Original Issue
SAP/ui5-webcomponents-react#674
@Lukas742
Copy link
Collaborator Author

Lukas742 commented Sep 9, 2020 •
edited
Loading

I just noticed that there is already a similar issue open for the ui5-daterange-picker (#2182). If the problem has the same source (what I suspect), please feel free to close this one.

@Lukas742 Lukas742 mentioned this issue Sep 9, 2020
Closed
@fifoosid
Copy link
Contributor

This issue is still relevant.

@tsanislavgatev tsanislavgatev mentioned this issue Sep 11, 2020
Merged
@tsanislavgatev tsanislavgatev self-assigned this Sep 14, 2020
@ilhan007 ilhan007 added this to the 1.0.0-rc.9 milestone Sep 14, 2020
This was referenced Oct 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsanislavgatev tsanislavgatev

Labels
None yet
Projects
None yet
Milestone
1.0.0-rc.9
Development

Successfully merging a pull request may close this issue.

fix(ui5-calendar): Year text is now right in all timezones SAP/ui5-webcomponents
4 participants
@Lukas742 @tsanislavgatev @ilhan007 @fifoosid