Skip to content

ui5-textarea: Required field is not informed when keyboard tab focus is set on Activity Name field #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GongRichard opened this issue Oct 20, 2020 · 6 comments

Comments

@GongRichard
Copy link

Describe the bug
Required field is not informed when keyboard tab focus is set on Activity Name field

To reproduce
Steps to reproduce the behavior:

  1. Go to https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock#/goal-list
  2. click 'Skip Tour' button
  3. click more actions button on the top right of Goal Card
  4. click 'Create Activity' button
  5. With JAWS ON, using keyboard tab key navigate the contents of modal window

Actual Results
When focus is set on 'Activity Name' textarea with tab key, JAWS doesn't announce it as required field.
Note : In forms mode, with arrow keys navigation the field is announced as required. aria-required="true" is used.

Expected behavior
When form fields are navigated using keyboard tab key, the Activity Name input field which is mandatory field should be announced as required by JAWS.

Tested with other screen reader NVDA and NVDA does announce input form field as 'required'. Please find the attached recording for NVDA and JAWS screen reader.

The textarea tag along with required and aria-required was tested in w3.org and JAWS was announcing the required field correctly with TAB key. Please find the attached screenshot.

Suggestion : Instead of using both attributes 'required' and' aria-required' try using only one and test with JAWS.

Screenshots
2020-09-21_20-01-36 (1)
Example on w3 org
JAWS required input field
Required field announced in Virtual PC mode
Tab key required attribute issue

Context

  • UI5 Web Components version: 0.23.2
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}

Organization:
SF

Priority:
Medium

@niyap
Copy link
Contributor

niyap commented Dec 7, 2020

Dear @GongRichard,
Thanks for the detailed description!

Unfortunately , I am not able to access your application.

I checked the described issue in the available samples:

  1. https://sap.github.io/ui5-webcomponents/master/playground/main/pages/TextArea/ - "Required TextArea" sample
  2. https://sap.github.io/ui5-webcomponents/playground/components/TextArea/ - adding "required" to the first sample
    and I am not able to reproduce the issue. In both samples "required" is read out.

For testing purposes, I used JAWS19 + Chrome, navigating via TAB (virtual cursor off)

Could you please check once again if the issue still persist from your side and if so, please reopen the incident and allow access to your application.

Regards,
Niya

@niyap niyap closed this as completed Dec 7, 2020
@GongRichard
Copy link
Author

@niyap , this issue still can be reproduced by SF A11Y team, please have a check. The above page can access now.

Hello Richard,

I revalidated and issue still exist and JAWS does not announce 'required' when focused with TAB key. Many screen reader user do navigate page with TAB key so this issue needs to be taken into consideration.

For reference - I edited the html code, just added required inside <textarea> and JAWS did announced as 'required'.

Please find attached screenshot for reference.

By adding 'required' inside the <textarea> element may resolve the issue.

Thanks,

Preeti DEshmukh

Still an issue WEF-3842
Edited WEF-3842

@ilhan007 ilhan007 reopened this Jan 20, 2021
@niyap
Copy link
Contributor

niyap commented Jan 20, 2021

Hello @GongRichard,

I am a little bit confused. Now, the application is accessible but I was not able to reproduce the issue.
I check the ui5-textarea within "Create Activity" dialog, as well as the one in "Create Goal" but the issue is not reproducible from my side. "Required" is always announced.
I checked with JAWS19 + Chrome, then I tried with JAWS18 as well. I checked both with virtual cursor and without, but without result.

Could you please give me detailed information, how do you manage to reproduce it?
Please, specify JAWS and Chrome versions and step by step description how to reproduce the issue in order to be able to support you.

Thank you in advance!

Kind Regards,
Niya

@GongRichard
Copy link
Author

@niyap this was tested by SF A11Y quality team. What's your sap internal email address? I send email to you and our SF QA.

@niyap
Copy link
Contributor

niyap commented Jan 21, 2021

Hello @GongRichard,

My email is: [email protected]

Kind Regards,
Niya

@ilhan007 ilhan007 removed this from the 1.0.0-rc.12 milestone Jan 28, 2021
@GongRichard
Copy link
Author

Niya has confirmed with SF QA, this is not an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

5 participants