Skip to content

<ui5-list> will emit "item-click" event when the child item contains a button and "enter" on it #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BodhiHu opened this issue Nov 11, 2020 · 2 comments · Fixed by #2462
Assignees

Comments

@BodhiHu
Copy link

BodhiHu commented Nov 11, 2020

Describe the bug

The <ui5-list> will emit "item-click" event when the child item contains a button and user "enter" on it using keyboard.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/ui5-webcomponents-forked-qgwcz?file=/index.html;
  2. Inside the rendered sandbox, tab to the button "List Button 1" using keyboard and press "Enter";
  3. Both the child button's "click" and list's "item-click" events will be triggered (showing an alert);

Isolated example

https://codesandbox.io/s/ui5-webcomponents-forked-qgwcz?file=/index.html

Expected behavior

Should only the child button"click" event be emitted

Screenshots
NA

Context

  • UI5 Web Components version: 1.0.0-rc.9
  • OS/Platform: MacOS
  • Browser (if relevant): Chrome
  • Other information: NA

Affected components (if known)

<ui5-list>

Log output / Any errors in the console

NA

Organization: (if applicable)

SF

Priority: (optional) (Low, Medium, High or Very High)

Medium

Setting priority would indicate the importance of the issue
and would help the process of dispatching and processing.

To set the appropriate priority, you need to consider the impact
and if the issue:

  • Breaks entire application or system - High and Very High
  • Is accessibility one (Screan Reader, Keyboard Handling) - Medium and High
  • Is functional one and makes a single component unusable - Medium and High
  • Is visual, styling one - Low and Medium

Note: the priority would be re-evaluated by the issue processors, according to the project internal criterias

Business impact: (mandatory for "Very High")

NA

@BodhiHu
Copy link
Author

BodhiHu commented Nov 11, 2020

screen recording 720p.mov.zip

Uploaded the screen recordings.

@BodhiHu
Copy link
Author

BodhiHu commented Nov 17, 2020

Hi @fifoosid ,

Seems there's now a PR for this issue, can you please tell when will the PR be released ?

Thanks & Best Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants