fix(ui5-select): correct role and screen reader speech out #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
requested review from
elenastoyanovaa,
dobrinyonkov,
ilhan007 and
fifoosid
elenastoyanovaa
approved these changes
Dec 21, 2020
ilhan007
pushed a commit
that referenced
this pull request
Jan 13, 2021
- Role of the ui5-select is changed to combobox which change the speech output near to the default behavior. - The issue where role="button" can't be used with aria-required / required attribute is fixed. - Overwriting the aria-label speech output with aria-labelledby is fixed. Fixes: #2485 Fixes: #2339 Fixes: #2142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Role of the ui5-select is changed to combobox which change the speech output near to the default behavior. Issue where role="button" can't be used with aria-required / required attribute is fixed. Overwriting the aria-label speech output with aria-labelledby is fixed.
Fixes: #2485
Fixes: #2339
Fixes: #2142