feat(ui5-product-switch): Implement accessibility specification #2865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
previously approved these changes
Feb 25, 2021
There was a problem hiding this comment.
It looks good to me, but let's wait for @elenastoyanovaa to review from a11y perspective.
Just a reminder to update the a11y page afterwards:
https://wiki.wdf.sap.corp/wiki/pages/viewpage.action?pageId=2382053438
|
I'm keeping this as a draft as it needs some further discussion in regards of the grid like navigation (arrows - up, down, left, right). The role menu -> menuitem and aria-setsize and posinset attributes may not be the most appropriate ones. I will discuss this with accessibility experts on the next round. |
dobrinyonkov
force-pushed
the
product-switch-acc
branch
2 times, most recently
from
e855efe to
57e3ac9
Compare
dobrinyonkov
force-pushed
the
product-switch-acc
branch
from
57e3ac9 to
cd5a6e7
Compare
nnaydenow
reviewed
Apr 21, 2021
dobrinyonkov
force-pushed
the
product-switch-acc
branch
from
cd5a6e7 to
dc8e5ea
Compare
|
Hi @ilhan007, For me the change looks okey. Can you approve it? |
ilhan007
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #2707
Additionally:
UP and DOWN arrow keys navigation is updated, and limited to the product switch borders.