feat(ui5-avatar-group): new slot overflowButton #3037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
reviewed
Mar 29, 2021
There was a problem hiding this comment.
IMO looks great, almost ready to merge.
I would suggest 2 minor things:
- You have 2 checks: _hasOverflowButton (which is this.overflowButton.length) and in many places in the code there is this.overflowButton[0]. Please merge these in a single getter: _customOverflowButton which returns null/undefined or this.overflowButton[0]. Then use this getter in place of both this.overflowButton.length and this.overflowButton[0]
- in the html example, add arialabel to demonstrate the feature they wanted
ilhan007
reviewed
Mar 29, 2021
ilhan007
requested changes
Mar 29, 2021
ilhan007
approved these changes
Mar 30, 2021
ilhan007
pushed a commit
that referenced
this pull request
Mar 31, 2021
Added new slot which allows to add custom overflow button and "overflow" event to let you know when avatars hide/show in order to update the overflow button text. If not provided, the AvatarGroup will display the built-in overflow button. The slot is provided to allow you defining the text of the overflow button and let you set additional aria attributes, such as aria-label. Fixes: #2912
ilhan007
pushed a commit
that referenced
this pull request
Mar 31, 2021
Added new slot which allows to add custom overflow button and "overflow" event to let you know when avatars hide/show in order to update the overflow button text. If not provided, the AvatarGroup will display the built-in overflow button. The slot is provided to allow you defining the text of the overflow button and let you set additional aria attributes, such as aria-label. Fixes: #2912
ilhan007
pushed a commit
that referenced
this pull request
Mar 31, 2021
Added new slot which allows to add custom overflow button and "overflow" event to let you know when avatars hide/show in order to update the overflow button text. If not provided, the AvatarGroup will display the built-in overflow button. The slot is provided to allow you defining the text of the overflow button and let you set additional aria attributes, such as aria-label. Fixes: #2912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new slot which allows to add custom overflow button and "overflow" event to let you know when avatars
hide/show in order to update the overflow button text. If not provided, the AvatarGroup will display the built-in overflow button. The slot is provided to allow you defining the text of the overflow button and let you set additional aria attributes, such as aria-label.
Fixes: #2912