feat(ui5-static-area-item): StaticAreaItem can now be scoped #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskelin
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: when new and old versions of UI5 Web Components are mixed on the same page and the old version has already upgraded the
ui5-static-area-itemtag, it will not have some of the newer functions. Therefore it should be scoped along with the other tags.Changes:
StaticAreaItems.jscan now be scopedUI5Element.jsdelegates the creation of new static area items toStaticAreaItem.jsNote:
ui5-static-area-itemtag is defined lazily now, so that the app has had the chance to set the scoping suffixAdditionally:
ui5-wizardandui5-wizard-stephave been made scoping-friendly