Skip to content

A11Y issue with ui5-rating-indicator when it is on readonly mode #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hkshetry opened this issue Apr 30, 2021 · 3 comments · Fixed by #3219
Closed

A11Y issue with ui5-rating-indicator when it is on readonly mode #3203

hkshetry opened this issue Apr 30, 2021 · 3 comments · Fixed by #3219
Assignees
Labels

Comments

@hkshetry
Copy link

hkshetry commented Apr 30, 2021

Describe the bug

Jaws will announce "To increase or decrease use the arrow keys." when ui5-rating-indicator is on read only mode. The announcement "to increase or decrease use arrow keys" and "slider" role are appropriate only if the star rating is on Edit mode so Rating component should be role="slider" with aria-readonly=true on Read only mode

To reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/ui5-webcomponents-forked-bkucb?file=/index.html
  2. Turn on screen reader and Navigate to Rating Indicator
  3. Rating Indicator announce "To increase or decrease use the arrow keys."

Isolated example
https://codesandbox.io/s/ui5-webcomponents-forked-bkucb?file=/index.html

Expected behavior
aria-readonly=true should be present in HTML DOM Element

Context

  • UI5 Web Components version 0.29.6
  • OS/Platform: NA
  • Browser (if relevant): Chrome Version 89.0.4389.82 (Official Build) (64-bit)
  • Other information: NA

Affected components
ui5-rating-indicator

Organization:
SuccessFactor

Priority:
High

@hkshetry hkshetry changed the title A11Y issue with ui5-rating-indicator when it is readonly mode A11Y issue with ui5-rating-indicator when it is on readonly mode Apr 30, 2021
@fifoosid fifoosid added the SAP SF label May 5, 2021
@niyap
Copy link
Contributor

niyap commented May 10, 2021

Hello @hkshetry,

Thanks for sharing your findings!

The speech output comes from the role 'slider' and it is expected. Even using native HTML example, without UI5 Web Components, the speech output is the same when you have an element with role='slider'. Here, is a sample: https://jsbin.com/jerelitoyo/edit?html,output
You are right that aria-readonly="true" is not added when the RatingIndicator is readonly and we will enhance it, but that will not change the speech output.

Kind Regards,
Niya

@niyap
Copy link
Contributor

niyap commented May 10, 2021

Hello Colleagues,

When we have a read-only , aria-readonly="true" should be added to the root element.

Kind Regards,
Niya

@ilhan007
Copy link
Member

Hi @hkshetry fixed with 0.29.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants