feat(ui5-carousel): add property hide-page-indicator #3268
Conversation
georgimkv
requested review from
a team,
ilhan007,
vladitasev,
pskelin and
fifoosid
| } | ||
|
|
||
| _onmouseover() { | ||
| this._visibleNavigationArrows = true; | ||
| if (this.arrowsPlacement === CarouselArrowsPlacement.Content) { | ||
| this._visibleNavigationArrows = true; |
There was a problem hiding this comment.
there is a property "hideNavigationArrows", is it considered here?
There was a problem hiding this comment.
It was deleted by #3228
There was a problem hiding this comment.
Yes. The check for hideNavigationArrows happens during rendering. At this point in execution, it is established that arrowsPlacement will not change.
|
You stated that "the arrows are always visible when arrowsPlacement is set to Navigation". |
The property |
The page indicator can now be hidden by setting the property hide-page-indicator on the ui5-carousel element. - the arrows are always visible when `arrowsPlacement` is set to `Navigation` - fixed typos - changed height reduction of the carousel viewport to 1rem
georgimkv
force-pushed
the
carousel-hide-page-indicator
branch
from
0f04d8e to
837b315
Compare
The page indicator can now be hidden by setting the property
hide-page-indicator on the ui5-carousel element.
arrowsPlacementis set toNavigationCloses: #3158