fix(ui5-responsive-popover): fixed position of downward pointing arrow #3508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResponsivePopover resets the custom property `_ui5_popup_content_padding` as it is used by other components. The calculation for the position of the arrow depended on the padding, and the calculation will be wrong when the padding is set to "0". Solved by changing the positioning of the arrow by using `top`. Fixes #3500
alexandar-mitsev
approved these changes
Jul 16, 2021
kineticjs
pushed a commit
to kineticjs/ui5-webcomponents
that referenced
this pull request
Jul 20, 2021
SAP#3508) ResponsivePopover resets the custom property `_ui5_popup_content_padding` as it is used by other components. The calculation for the position of the arrow depended on the padding, and the calculation will be wrong when the padding is set to "0". Solved by changing the positioning of the arrow by using `top`. Fixes SAP#3500
ilhan007
pushed a commit
that referenced
this pull request
Jul 26, 2021
#3508) ResponsivePopover resets the custom property `_ui5_popup_content_padding` as it is used by other components. The calculation for the position of the arrow depended on the padding, and the calculation will be wrong when the padding is set to "0". Solved by changing the positioning of the arrow by using `top`. Fixes #3500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponsivePopover overrides the custom property
_ui5_popup_content_paddingas it is used by other components.
The calculation for the position of the arrow depends on this padding,
and the calculation will be wrong when the padding is set to "0".
Solved by changing the positioning of the arrow by using
top.Fixes #3500