Skip to content

fix(ui5-responsive-popover): fixed position of downward pointing arrow #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

georgimkv
Copy link
Contributor

@georgimkv georgimkv commented Jul 15, 2021

ResponsivePopover overrides the custom property _ui5_popup_content_padding
as it is used by other components.

The calculation for the position of the arrow depends on this padding,
and the calculation will be wrong when the padding is set to "0".

Solved by changing the positioning of the arrow by using top.

Fixes #3500

ResponsivePopover resets the custom property `_ui5_popup_content_padding`
as it is used by other components.

The calculation for the position of the arrow depended on the padding,
and the calculation will be wrong when the padding is set to "0".

Solved by changing the positioning of the arrow by using `top`.

Fixes #3500
@georgimkv georgimkv requested review from ilhan007, a team and fifoosid July 15, 2021 12:49
@ilhan007 ilhan007 merged commit e0744d6 into master Jul 16, 2021
@ilhan007 ilhan007 deleted the popover_arrow_top_fix branch July 16, 2021 12:37
kineticjs pushed a commit to kineticjs/ui5-webcomponents that referenced this pull request Jul 20, 2021
SAP#3508)

ResponsivePopover resets the custom property `_ui5_popup_content_padding`
as it is used by other components.
The calculation for the position of the arrow depended on the padding,
and the calculation will be wrong when the padding is set to "0".
Solved by changing the positioning of the arrow by using `top`.

Fixes SAP#3500
ilhan007 pushed a commit that referenced this pull request Jul 26, 2021
#3508)

ResponsivePopover resets the custom property `_ui5_popup_content_padding`
as it is used by other components.
The calculation for the position of the arrow depended on the padding,
and the calculation will be wrong when the padding is set to "0".
Solved by changing the positioning of the arrow by using `top`.

Fixes #3500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<ui5-responsive-popover placement-type="Top"> visual issue with pointer
3 participants