Skip to content

fix(ui5-select): preselect first item if none is selected #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Apr 23, 2019

  • Pressing escape now reverts the selection before openinig the picker
  • Focusing out the popover now triggers a change event (if selection is changed)

Fixes: #339

- Pressing escape now reverts the selection before openinig the picker
- Focusing out the popover now triggers a change event (if selection is changed)

Fixes: #339
@MapTo0 MapTo0 requested a review from ilhan007 April 23, 2019 13:13
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall seems complex, let's discuss together tomorrow

@MapTo0 MapTo0 merged commit 3d18420 into master Apr 24, 2019
@MapTo0 MapTo0 deleted the select-selection-fix branch April 24, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select "cannot read property 'textContent' of null"
3 participants