Skip to content

feat: add configuration for first day of the week #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2019
Merged

feat: add configuration for first day of the week #627

merged 5 commits into from
Aug 7, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Jul 4, 2019 •
edited by vladitasev
Loading

  • global configuration field is added - formatSettings, with firstDayOfWeek as one of them
  • e.g. firstDayOfWeek: 3 => all calendars should show Wednesday as first

FIXES: #626
FIXES: #585

@MapTo0
feat: add configuration for first day of the week
14b1111 
- global configuration field is added - firstDayOfTheWeek
- e.g. firstDayOfTheWeek: 3 => all calendars should show Wednesday as first

FIXES: #626
FIXES: #585
@pskelin
Copy link
Contributor

pskelin commented Jul 4, 2019

It might be necessary to configure everything in the format settings, so a different configuration API might be better. Let’s discuss this in more detail first.

@vladitasev vladitasev requested review from pskelin, ilhan007 and vladitasev and removed request for vladitasev August 7, 2019 10:26
@vladitasev vladitasev merged commit 9c6df48 into master Aug 7, 2019
@vladitasev vladitasev deleted the first-day-of-week branch August 7, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@pskelin pskelin Awaiting requested review from pskelin

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MapTo0 @pskelin @vladitasev