feat: enable property decorator for property accessors #8587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to use the
@property
decorator on a property accessor like this:The main use case for this is to to synchronously make a DOM operation (like adding a class to show the dialog when a property is set), as the normal setting of a property triggers an async rendering cycle. A real use case is setting the focus to the first element of the dialog will show the iOS keyboard only if it is in the same tick as the click handler that triggered the operation (#8583)
Implementation
Previously, the
@property
decorator was overwriting such accessors and using the internal UI5Element_state
for storage. With this change, if an accessor pair exists, it will be used for storage, this triggering the custom logic.Additionally, setting the property will still trigger invalidation, as well as update the attribute in the DOM.