Skip to content

fix(ui5-shellbar): scope internally used icons #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented Apr 3, 2024

Icons used inside ui5-shellbar's template are not scoped because ui5-icon is not described as dependency of it. In addition slim-arrow-down is imported otherwise it wasn't loaded.

Fixes: #8609

@ilhan007 ilhan007 merged commit 8419ac5 into main Apr 3, 2024
@ilhan007 ilhan007 deleted the shellbar-icon branch April 3, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-shellbar]: ui5-icon is missing scoping
2 participants