Skip to content

feat(ui5-carousel): add accessibleName and accessibleNameRef #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Apr 4, 2024

Adds accessibleName and accessibleNameRef public properties to allow consumers set accessible label on the Carousel.

    <ui5-title id="imgGallery" level="H4">Image Gallery</ui5-title>
    <ui5-carousel accessible-name-ref="imgGallery">
        <img src="../assets/images/sample1.jpg" alt="Landscape 1">
        <img src="../assets/images/sample2.jpg" alt="Landscape 2">
        <img src="../assets/images/sample3.jpg" alt="Bulb">
    </ui5-carousel>
    
      <ui5-carousel accessible-name="Image Gallery">
        <img src="../assets/images/sample1.jpg" alt="Landscape 1">
        <img src="../assets/images/sample2.jpg" alt="Landscape 2">
        <img src="../assets/images/sample3.jpg" alt="Bulb">
    </ui5-carousel>

Fixes: #8472

@ilhan007 ilhan007 requested a review from TeodorTaushanov April 4, 2024 07:57
@ilhan007 ilhan007 merged commit 0d0d765 into main Apr 4, 2024
@ilhan007 ilhan007 deleted the fix-carousel-a11y branch April 4, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Carousel]: Accessibility issue - Section with role="listbox" missing a label
2 participants