-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding run-clang-format to PyPI #37
Comments
Hello, See my previous answer here: |
Thanks for the quick response @Sarcasm! From my point of view, as a user, it's a lot nicer to be able to be able install this as part as any other Python dependencies and run it like any other tool (specially since CMake and Ninja are also in PyPI). Even more so in a CI environment, where we can easily get everything installer with a single I've be happy to submit a PR to sort out the packaging, and to configure GitHub actions to submit it to PyPI via github tag if that helps? That way the only thing needed is to set up the PyPI keys via GitHub secrets and push a git tag to get the automation going. If you still prefer not to package it, would you be against somebody else packaging it and publishing to PyPI? Of course, I'd make sure the description clearly gives the proper attribution an indicates all packaing issues should be directed to a different issue tracker. |
The thing is that run-clang-format.py is deliberately dependency-less (just Python stdlib and clang-format). Thinking about it, if I really wanted to package it, I would consider upstreaming it to the llvm project, like That said, I can consider a PR for a PyPI package via Github actions and I would not be offended by an independent pip package either. |
First of all, thanks for creating this great wrapper around clang-format, it makes running it locally and on CI much more easy and useful!
Now that clang-format is packaged in PyPI (https://pypi.org/project/clang-format/) would you consider adding this package to PyPI and configuring
clang-format
as a dependency? That way users could justpip install run-clang-format
(or even better using pipx we couldpipx install run-clang-format
!), and be able to use this tool very easily.The text was updated successfully, but these errors were encountered: