Refactor ssp_process_traces #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a bug where "p_arrival_tolerance" was used also for S waves
|
I will try to test before leaving on holiday! |
|
Claudio, I ran 2 tests. I obtain slightly different Mw values, but these are likely due to a new default value for |
|
Thank you Kris for this quick test! Have a nice Easter holiday! 🐣 |
This happened in certain cases when using `spectral_win_length`
claudiodsf
force-pushed
the
refactor_process_traces
branch
from
6f1f4de to
7245cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to catch a bug, I realized that the code in
ssp_process_traces.py(and some other functions in other files) was quite hard to understand.I therefore tried to split it into smaller functions.
I also caught a rare bug in plotting time windows, in the process 😄
Hopefully, I didn't break anything. But, since some of the code I moved around is @krisvanneste's, I prefer that --Kris-- you make some check. Thanks!