Skip to content

sql_output_outlier #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

krisvanneste
Copy link
Collaborator

Patch to include information about outliers for each parameter in the Stations table in the SQL output.

@claudiodsf
Copy link
Member

Hi Kris, thanks for this PR!

And sorry for not reacting to the previous one. I'm back on track now and will evaluate both PR this afternoon 😉

@krisvanneste
Copy link
Collaborator Author

No worries.

@claudiodsf claudiodsf force-pushed the sql_output_outlier branch from 5481582 to e77bd77 Compare June 26, 2023 15:05
claudiodsf added a commit to krisvanneste/sourcespec that referenced this pull request Jun 26, 2023
claudiodsf added a commit to krisvanneste/sourcespec that referenced this pull request Jun 26, 2023
@claudiodsf claudiodsf force-pushed the sql_output_outlier branch from 51b137e to 95544e1 Compare June 26, 2023 15:20
claudiodsf added a commit to krisvanneste/sourcespec that referenced this pull request Jun 26, 2023
@claudiodsf claudiodsf force-pushed the sql_output_outlier branch from 95544e1 to 639577d Compare June 26, 2023 15:23
@claudiodsf
Copy link
Member

Ok for me (after adding the outlier information also for the radiated energy 😉).

Note that I had to increment DB_VERSION since the database schema has changed.

I profited of this change to reorder the fields, so that radiated energy is before distance and azimuth.

Ok to merge after a double-check on your side 👍

@claudiodsf claudiodsf force-pushed the sql_output_outlier branch from 639577d to f227532 Compare June 27, 2023 08:17
@krisvanneste
Copy link
Collaborator Author

Works for me.

@claudiodsf
Copy link
Member

Rebased and force-pushed.
@krisvanneste, could you double-check?

P.S. I will profit of the DB_VERSION change to make other modifications in the DB, directly on the main branch, after this PR is merged.

@claudiodsf
Copy link
Member

Ok, merging!

@claudiodsf claudiodsf merged commit 3953a54 into SeismicSource:main Jun 27, 2023
@claudiodsf
Copy link
Member

I pushed 44c5d2d with more DB modifications.

Hopefully, it doesn't break anything 😉

@krisvanneste
Copy link
Collaborator Author

Nice bit of refactoring!

@claudiodsf
Copy link
Member

Nice bit of refactoring!

Thanks to Copilot and Sourcery 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants