Skip to content

Fixes related to records with short signal windows #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2023
Merged

Fixes related to records with short signal windows #39

merged 3 commits into from
Jun 27, 2023

Conversation

krisvanneste
Copy link
Collaborator

Two minor fixes related to records with short signal windows, which I encountered when running sourcespec on my collection of events:

  • fix to avoid taper length gets too large in _build_weight_from_ratio function.
  • fix to improve end time of P window in _define_signal_and_noise_windows function.

Here is an illustration of the second case before and after:
905 traces

905 traces

@claudiodsf
Copy link
Member

I will rebase this on main after merging #37, since both imply modifications in ssp_build_spectra.py

@krisvanneste @claudiodsf
Ensure taper length is not larger than 0.25 in _build_weight_from_rat…
ea0c1b5 
…io()

May arise when signal window is very short

(cherry picked from commit 37646a1)
@krisvanneste @claudiodsf
Improved end time of P window for records with short S-P interval in …
9cc0919 
…_define_signal_and_noise_windows function.

(cherry picked from commit 500a91e)
@claudiodsf claudiodsf merged commit 7bf9864 into SeismicSource:main Jun 27, 2023
@claudiodsf
Copy link
Member

Merged! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisvanneste @claudiodsf