-
Notifications
You must be signed in to change notification settings - Fork 13
run_id #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
run_id #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi kris, thanks for the pull request. I'm adding a few extra commits and I'll let you know when I'm done. |
(cherry picked from commit 4552227b3fcc3218d794032362c85ccb629b87c3)
(cherry picked from commit 54349735c2233126f57b22fab5c8e80733feea84)
2dff555
to
e35ff4d
Compare
claudiodsf
added a commit
to krisvanneste/sourcespec
that referenced
this pull request
Jul 18, 2022
Hi @krisvanneste, Let me know if it's ok for you as well, so that I'll merge. |
Claudio, Kris |
Great! Merged! Thanks again |
claudiodsf
added a commit
to krisvanneste/sourcespec
that referenced
this pull request
Jul 18, 2022
* Added `--run_id` command-line argument in `_update_parser` function. * Add optional `run_id` to new `outdir` name in `move_outdir` function. * Add `runid` field to station and event tables in `_write_db` function. * Write `run_id` (if not empty) to parfile * Write `run_id` (if not empty) to HTML report * Changelog for PR SeismicSource#6 * Add Kris to contributors ;-) Co-authored-by: Claudio Satriano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature branch adds a --run-id command-line argument to source_spec. The run_id is used to name the output folder and is also added in a dedicated field in the database. This allows running source_spec with different configurations for the same event without overwriting the corresponding results.