Skip to content

Commit 5f42b30

Browse files
committed
update: config basicAuth.enabled is false by default
Advanced features will be enabled by user on demand. Fixes: #2285 Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent c8cd02b commit 5f42b30

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ NAMESPACE := $(or $(NAMESPACE),$(NAMESPACE),$(NAME))
1313
AUTHORS := $(or $(AUTHORS),$(AUTHORS),SeleniumHQ)
1414
PUSH_IMAGE := $(or $(PUSH_IMAGE),$(PUSH_IMAGE),false)
1515
FROM_IMAGE_ARGS := --build-arg NAMESPACE=$(NAMESPACE) --build-arg VERSION=$(TAG_VERSION) --build-arg AUTHORS=$(AUTHORS) --sbom=true --attest type=provenance,mode=max
16-
BUILD_ARGS := $(BUILD_ARGS)
16+
BUILD_ARGS := $(BUILD_ARGS) --progress plain
1717
MAJOR := $(word 1,$(subst ., ,$(TAG_VERSION)))
1818
MINOR := $(word 2,$(subst ., ,$(TAG_VERSION)))
1919
MAJOR_MINOR_PATCH := $(word 1,$(subst -, ,$(TAG_VERSION)))

README.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -716,13 +716,13 @@ When using in Dynamic Grid, those variables should be combined with the prefix `
716716

717717
### Environment variables and default values for upload feature
718718

719-
| Environment variable | Default value | Description |
720-
|-------------------------------|---------------------------------------------|-------------------------------------------------------------------------------------------|
721-
| `SE_UPLOAD_RETAIN_LOCAL_FILE` | `false` | Keep local file after uploading successfully |
722-
| `SE_UPLOAD_COMMAND` | `copy` | RCLONE command is used to transfer file. Enforce `move` when retain local file is `false` |
723-
| `SE_UPLOAD_OPTS` | `-P --cutoff-mode SOFT --metadata--inplace` | Other options belong to RCLONE command can be set. |
724-
| `SE_UPLOAD_CONFIG_FILE_NAME` | `upload.conf` | Config file for remote host instead of set via env variable prefix SE_RCLONE_* |
725-
| `SE_UPLOAD_CONFIG_DIRECTORY` | `/opt/bin` | Directory of config file (change it when conf file in another directory is mounted) |
719+
| Environment variable | Default value | Description |
720+
|-------------------------------|----------------------------------------------|-------------------------------------------------------------------------------------------|
721+
| `SE_UPLOAD_RETAIN_LOCAL_FILE` | `false` | Keep local file after uploading successfully |
722+
| `SE_UPLOAD_COMMAND` | `copy` | RCLONE command is used to transfer file. Enforce `move` when retain local file is `false` |
723+
| `SE_UPLOAD_OPTS` | `-P --cutoff-mode SOFT --metadata --inplace` | Other options belong to RCLONE command can be set. |
724+
| `SE_UPLOAD_CONFIG_FILE_NAME` | `upload.conf` | Config file for remote host instead of set via env variable prefix SE_RCLONE_* |
725+
| `SE_UPLOAD_CONFIG_DIRECTORY` | `/opt/bin` | Directory of config file (change it when conf file in another directory is mounted) |
726726

727727
___
728728

charts/selenium-grid/CONFIGURATION.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
6666
| tls.disableHostnameVerification | bool | `true` | Disable verification the hostname included in the server's TLS/SSL certificates matches the hostnames provided |
6767
| registrationSecret.enabled | bool | `false` | Enable feature node registration secret to make sure that the node is one you control and not a rouge node |
6868
| registrationSecret.value | string | `"HappyTesting"` | The secret value to be used for node registration |
69-
| basicAuth.enabled | bool | `true` | Enable or disable basic auth for the Hub/Router |
69+
| basicAuth.enabled | bool | `false` | Enable or disable basic auth for the Hub/Router |
7070
| basicAuth.username | string | `"admin"` | Username for basic auth |
7171
| basicAuth.password | string | `"admin"` | Password for basic auth |
7272
| isolateComponents | bool | `false` | Deploy Router, Distributor, EventBus, SessionMap and Nodes separately |

charts/selenium-grid/values.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ registrationSecret:
104104
# Basic auth settings for Selenium Grid
105105
basicAuth:
106106
# -- Enable or disable basic auth for the Hub/Router
107-
enabled: true
107+
enabled: false
108108
# -- Username for basic auth
109109
username: admin
110110
# -- Password for basic auth

0 commit comments

Comments
 (0)