Skip to content

Commit c419716

Browse files
committed
update: adjust default value of env var SE_BROWSER_LEFTOVERS_PROCESSES_SECS
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 3909301 commit c419716

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

Diff for: .github/workflows/helm-chart-test.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,22 @@ jobs:
3838
cluster: 'kind'
3939
helm-version: 'v3.10.3'
4040
test-existing-keda: true
41-
- k8s-version: 'v1.26.14'
41+
- k8s-version: 'v1.26.15'
4242
test-strategy: deployment
4343
cluster: 'kind'
4444
helm-version: 'v3.11.3'
4545
test-existing-keda: true
46-
- k8s-version: 'v1.27.11'
46+
- k8s-version: 'v1.27.12'
4747
test-strategy: job_https
4848
cluster: 'kind'
4949
helm-version: 'v3.12.3'
5050
test-existing-keda: true
51-
- k8s-version: 'v1.28.7'
51+
- k8s-version: 'v1.28.8'
5252
test-strategy: job_hostname
5353
cluster: 'minikube'
5454
helm-version: 'v3.13.3'
5555
test-existing-keda: false
56-
- k8s-version: 'v1.29.2'
56+
- k8s-version: 'v1.29.3'
5757
test-strategy: deployment_https
5858
cluster: 'minikube'
5959
helm-version: 'v3.14.3'

Diff for: NodeBase/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ RUN chmod -R 775 ${HOME} /tmp/.X11-unix \
138138
#============================================
139139
ENV SE_ENABLE_BROWSER_LEFTOVERS_CLEANUP false
140140
ENV SE_BROWSER_LEFTOVERS_INTERVAL_SECS 3600
141-
ENV SE_BROWSER_LEFTOVERS_PROCESSES_SECS 1200
141+
ENV SE_BROWSER_LEFTOVERS_PROCESSES_SECS 7200
142142
ENV SE_BROWSER_LEFTOVERS_TEMPFILES_DAYS 1
143143

144144
#===================================================

Diff for: README.md

+8-3
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ Talk to us at https://www.selenium.dev/support/
5757
* [Increasing session concurrency per container](#increasing-session-concurrency-per-container)
5858
* [Running in Headless mode](#running-in-headless-mode)
5959
* [Stopping the Node/Standalone after N sessions have been executed](#stopping-the-nodestandalone-after-n-sessions-have-been-executed)
60+
* [Automatic browser leftovers cleanup](#automatic-browser-leftovers-cleanup)
6061
* [Building the images](#building-the-images)
6162
* [Waiting for the Grid to be ready](#waiting-for-the-grid-to-be-ready)
6263
* [Adding a HEALTHCHECK to the Grid](#adding-a-healthcheck-to-the-grid)
@@ -956,7 +957,7 @@ environment variables:
956957

957958
* `SE_ENABLE_BROWSER_LEFTOVERS_CLEANUP`: default value `false`, set to `true` to enable the cleanup.
958959
* `SE_BROWSER_LEFTOVERS_INTERVAL_SECS`: default value `3600` (1 hour), cleanup interval in seconds.
959-
* `SE_BROWSER_LEFTOVERS_PROCESSES_SECS`: default value `1200` (2 hours), browsers running for longer than this time will be killed.
960+
* `SE_BROWSER_LEFTOVERS_PROCESSES_SECS`: default value `7200` (2 hours), browsers running for longer than this time will be killed.
960961
* `SE_BROWSER_LEFTOVERS_TEMPFILES_DAYS`: default value `1` (1 day), files generated by Chrome-based browsers in `/tmp` will be removed after these number of days (ignored when using Firefox).
961962

962963
If you use Selenium for long-running sessions and expect browsers to be running for longer than 20 minutes, either do
@@ -970,11 +971,15 @@ $ docker run -e SE_ENABLE_BROWSER_LEFTOVERS_CLEANUP=true --shm-size="2g" seleniu
970971
With the previous command, the cleanup will be enabled with the default timings.
971972

972973
``` bash
973-
$ docker run -e SE_ENABLE_BROWSER_LEFTOVERS_CLEANUP=true -e SE_BROWSER_LEFTOVERS_INTERVAL_SECS=7200 -e SE_BROWSER_LEFTOVERS_PROCESSES_SECS=3600 -e SE_BROWSER_LEFTOVERS_TEMPFILES_DAYS=2 --shm-size="2g" selenium/node-chrome:4.18.1-20240224
974+
$ docker run -e SE_ENABLE_BROWSER_LEFTOVERS_CLEANUP=true \
975+
-e SE_BROWSER_LEFTOVERS_INTERVAL_SECS=7200 \
976+
-e SE_BROWSER_LEFTOVERS_PROCESSES_SECS=3600 \
977+
-e SE_BROWSER_LEFTOVERS_TEMPFILES_DAYS=2 \
978+
--shm-size="2g" selenium/node-chrome:4.18.1-20240224
974979
```
975980

976981
With the previous command, the cleanup will be enabled, but will run every 2 hours (instead of 1), will kill browsers
977-
running longer than 1 hour (instead of 20 minutes), and will remove temp files older than 2 days (instead of 1).
982+
running longer than 1 hour (instead of 2 hours), and will remove temp files older than 2 days (instead of 1).
978983

979984
___
980985

0 commit comments

Comments
 (0)