Skip to content

Duplicate code causes the node to fail to start when I am using environment variable SE_NODE_HOST or SE_NODE_PORT #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhq5101 opened this issue Dec 2, 2020 · 2 comments · Fixed by #1155

Comments

@zhq5101
Copy link

zhq5101 commented Dec 2, 2020

🐛 Bug Report

When I am using environment variable SE_NODE_HOST or SE_NODE_PORT, the node can not start. The main log is this:
cat /opt/selenium/config.toml
[node]
max-concurrent-sessions = 1
[events]
publish = "tcp://selenium-hub:4442"
subscribe = "tcp://selenium-hub:4443"

[server]
[server]
hostname = "selenium-node"
port = "5555"

There are two '[server]'s. And the reason is some duplicate code in this file:
https://github.com/SeleniumHQ/docker-selenium/blob/trunk/NodeChrome/generate_config
The line 13-17 is same as the line 19-23.

@ghost ghost added the needs-triaging label Dec 2, 2020
@diemol
Copy link
Member

diemol commented Dec 2, 2020

Thank you for reporting this, @zhq5101!
We will have a look soon.

@diemol
Copy link
Member

diemol commented Dec 2, 2020

Fixed in the linked PR, a release will follow soon.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants