-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[🐛 Bug]: Selenium 3 new browser images #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We won't provide any more images for Grid 3, maintaing both sets of images was already challenging, also because Grid 4.0 is the stable version now. I'll leave this issue open for a bit more in case more details are provided. |
Ok, understood. But threre is something weird with selenium 4 server. I made this sample project: https://github.com/cocorossello/selenium4-slow-driver-creation It's just a simple example that opens a few drivers with selenium 3 server and selenium 4 server (both use selenium 4 as the client). Selenium 4 is much slower, specially on subsequent invocations. This is probably not related to the docker images of course, but maybe selenium 4 activates some feature by default and this is what's making it much slower, I don't know. Do you have any cluse?
|
This comment has been minimized.
This comment has been minimized.
I have similar observations. |
Same here 🙏 |
Same here. :( |
I believe we're seeing this too. Our first Selenium 4 job took one hour longer (four hours vs three) than under Selenium 3.141.59. |
My setup is 1 hub and 50 nodes (all of them running on separate EC2 instances) and I'm using Protractor with sharding set to 50 to run the tests. What I have noticed is that when multiple concurrent session requests are hitting the hub it seems to be taking a long time to handle them. When I start the tests Protractor will send 50 session requests at almost the same time, but the nodes are just sitting there doing nothing for almost 2 minutes. Looking at the grid UI I saw the hub opening sessions and closing them and then opening new ones again. Looking at hub logs I can see that e.g. for first 3 concurrent session requests distributor needs 5s to handle 1st, 7s to handle 2nd and 10s to handle 3rd request This doesn't seem to be the case when there's only 1 session request (only 1 test running) and it starts right away. One additional thing is that Selenium 4 hub uses double the CPU that Selenium 3 hub was using under the same load |
Hi, I have been using selenium 4 images (just images, no GRID (no docker compose)), but faced really poor performance compared to selenium 3. Those are my major findings of selenium 4 docker images:
So we have now been using selenium 3 without any performance issues daily, but we would like to have support of the latest browsers... Are you considering on still maintaining selenium3 images until once selenium 4 performance issues will be fixed? Thanks a lot! |
Given there are a number of people experiencing some pretty serious issues with performance of Selenium 4, could I suggest that Selenium 3 images continue to be generated until these issues are investigated and resolved. These issues do not seem to be limited to use of Grid, and seem to affect Standalone too. A 25-35% drop in performance is really quite serious and will have a massive impact on build times. |
Hi @diemol. Apologies for tagging. I would like to get a confirmation if your above comments is still the case i.e is 3.141.59-20210929 the last docker image for Selenium 3? Knowing this will help us to prioritise our upgrade to Selenium 4. Thanks. |
I appreciatte your downvotes in my comment above. I do understand folks are just starting to try Grid 4 and finding things that could be improved. Before the holidays I found a couple of things that could be changed but there is literally a limilted amount of hours per day to work on this. So, maintaining this and also images for Grid 3 is way too much for me. I will be checking this in the next 2 weeks. If you want to add more comments to this thread, please add concrete things that I can use to analyse ways to make more improvements (such as the initial comment from @cocorossello). Most of the other comments have zero actionable facts that I can analyse. |
Hi @diemol, This issue is not limited to Hub. I've taken @cocorossello's gradle runner and run it against chrome standalone instead of hub, and these are my results: Java version:
Selenium versions:
ChromeVersions:
Results
FirefoxVersions
Results
SummaryI've run these tests quite a few times now, and the results are largely consistent. Selenium 4 is always approximately 4 times slower than Selenium 3. In my case I've removed Docker from the equation (because the Selenium images do not work reliably on ARM) so this issue really should be in an issue on the main seleniumhq/selenium project instead. I've also created a NodeJS performance tester to test the time to init and provide averages of each browser and selenium version. See https://github.com/andrewnicols/selenium-1444 for information. I have raised SeleniumHQ/selenium#10242 to look at this issue as it is not related to do the docker images. |
@diemol , can I ask what the time cost is to continue maintaining the Selenium 3 images? Where does the additional cost come from? I thought that their generation was largely automated now? |
Grid 3 images are not automated because they were being released from Travis, and when Travis limited our execution minutes, we were using Travis for Grid 3 and GitHub Actions for Grid 4. As development was advancing, we did not feel the need to update the pipeline for Grid 3 since it was going away. That is why a Grid 3 release would be manual now. |
The upstream performance problem with starting a new session has now been resolved. See SeleniumHQ/selenium#10242 and SeleniumHQ/selenium@7848221 for more information. I suspect that this will be available in Selenium 4.1.1. As a workaround, the |
Thank you! I can confirm that it works. Now times are something like:
(You still have to set - SE_SESSION_RETRY_INTERVAL=0 in the environment for this to work) |
Thanks for the feedback @cocorossello! I am pushing today a new release with |
Hi @diemol, Is it worth holding back another 24-48 hours before releasing a new set of images? A new version of chrome will be released tomorrow (1 Feb). In our case we need that version because it fixed a bug in chromedriver with scrolling elements into view before clicking on them. |
No worries, I can do a new release tomorrow. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
This is more a question than a issue. I see that images with chrome 95 are only being published with selenium 4.0.
I've migrated to selenium 4.0 in the client, however, we are still using selenium grid 3.0 in our selenium server. We run 80+ headless tests in parallel with chrome, it works with selenium grid 3 but it doesn't with 4.0, it's just too slow for some reason.
I would like to report on that issue, but I don't feel I can provide a lot of details, so I will stick to 3.0 until I see this issue fixed.
My question is if you will still provide selenium 3.0 images with new browsers, just to see what we can do.
Thanks.
Command used to start Selenium Grid with Docker
Relevant log output
Operating System
Ubuntu 20.04 LTS
Docker Selenium version (tag)
3.141.59-20210929
The text was updated successfully, but these errors were encountered: