Skip to content

Commit dbf34f9

Browse files
committed
adjust expectation for latest ESR
1 parent 919c855 commit dbf34f9

File tree

3 files changed

+29
-22
lines changed

3 files changed

+29
-22
lines changed

pom.xml

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>org.seleniumhq.selenium</groupId>
77
<artifactId>htmlunit3-driver</artifactId>
8-
<version>4.24.0-SNAPSHOT</version>
8+
<version>4.25.0-SNAPSHOT</version>
99

1010
<name>${project.artifactId}</name>
1111
<description>WebDriver compatible driver for HtmlUnit headless browser</description>
@@ -18,15 +18,16 @@
1818
<maven.compiler.source>11</maven.compiler.source>
1919
<maven.compiler.target>11</maven.compiler.target>
2020

21-
<selenium.version>4.23.0</selenium.version>
22-
<htmlunit.version>4.4.0</htmlunit.version>
21+
<selenium.version>4.25.0</selenium.version>
22+
<selenium.devtools.artifactId>selenium-devtools-v129</selenium.devtools.artifactId>
23+
<htmlunit.version>4.5.0-SNAPSHOT</htmlunit.version>
2324

24-
<jetty.version>9.4.55.v20240627</jetty.version>
25+
<jetty.version>9.4.56.v20240826</jetty.version>
2526

26-
<checkstyle.version>10.17.0</checkstyle.version>
27+
<checkstyle.version>10.18.2</checkstyle.version>
2728
<spotbugs.version>4.8.6</spotbugs.version>
2829
<archunit.version>1.3.0</archunit.version>
29-
<dependencycheck.version>10.0.3</dependencycheck.version>
30+
<dependencycheck.version>10.0.4</dependencycheck.version>
3031
</properties>
3132

3233
<licenses>
@@ -101,6 +102,12 @@
101102
<version>${selenium.version}</version>
102103
<scope>test</scope>
103104
</dependency>
105+
<dependency>
106+
<groupId>org.seleniumhq.selenium</groupId>
107+
<artifactId>${selenium.devtools.artifactId}</artifactId>
108+
<version>${selenium.version}</version>
109+
<scope>test</scope>
110+
</dependency>
104111
<dependency>
105112
<groupId>org.htmlunit</groupId>
106113
<artifactId>htmlunit</artifactId>
@@ -198,7 +205,7 @@
198205
<plugin>
199206
<groupId>org.apache.maven.plugins</groupId>
200207
<artifactId>maven-checkstyle-plugin</artifactId>
201-
<version>3.4.0</version>
208+
<version>3.5.0</version>
202209
<configuration>
203210
<configLocation>checkstyle.xml</configLocation>
204211
<suppressionsLocation>checkstyle_suppressions.xml</suppressionsLocation>
@@ -215,7 +222,7 @@
215222
<plugin>
216223
<groupId>com.github.spotbugs</groupId>
217224
<artifactId>spotbugs-maven-plugin</artifactId>
218-
<version>4.8.6.2</version>
225+
<version>4.8.6.4</version>
219226
<dependencies>
220227
<dependency>
221228
<groupId>com.github.spotbugs</groupId>
@@ -244,7 +251,7 @@
244251
<plugin>
245252
<groupId>org.apache.maven.plugins</groupId>
246253
<artifactId>maven-javadoc-plugin</artifactId>
247-
<version>3.8.0</version>
254+
<version>3.10.1</version>
248255
<configuration>
249256
<quiet>true</quiet>
250257
<detectLinks>true</detectLinks>
@@ -261,7 +268,7 @@
261268
<plugin>
262269
<groupId>org.apache.maven.plugins</groupId>
263270
<artifactId>maven-surefire-plugin</artifactId>
264-
<version>3.3.1</version>
271+
<version>3.5.1</version>
265272
<configuration>
266273
<includes>
267274
<include>**/*.java</include>
@@ -271,7 +278,7 @@
271278
<plugin>
272279
<groupId>org.apache.maven.plugins</groupId>
273280
<artifactId>maven-gpg-plugin</artifactId>
274-
<version>3.2.4</version>
281+
<version>3.2.7</version>
275282
<executions>
276283
<execution>
277284
<phase>verify</phase>

src/test/java/org/openqa/selenium/htmlunit/HtmlUnitAlertTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ public void unhandledAlerts2() throws Exception {
184184
}
185185

186186
@Test
187-
public void testCanQuitWhenAnAlertIsPresent() throws Exception {
187+
public void canQuitWhenAnAlertIsPresent() throws Exception {
188188
final String html = "<html>\n"
189189
+ "<head>\n"
190190
+ "</head>\n"
@@ -199,7 +199,7 @@ public void testCanQuitWhenAnAlertIsPresent() throws Exception {
199199
}
200200

201201
@Test(expected = ElementNotInteractableException.class)
202-
public void testSettingTheValueOfAnAlertThrows() throws Exception {
202+
public void settingTheValueOfAnAlertThrows() throws Exception {
203203
final String html = "<html>\n"
204204
+ "<head>\n"
205205
+ "</head>\n"
@@ -220,9 +220,9 @@ public void testSettingTheValueOfAnAlertThrows() throws Exception {
220220
@Test
221221
@Alerts("Unexpected alert found: HtmlUnit is great")
222222
@BuggyWebDriver(DEFAULT = "unexpected alert open: {Alert text : HtmlUnit is great}",
223-
FF = "Dismissed user prompt dialog: HtmlUnit is great",
224-
FF_ESR = "Dismissed user prompt dialog: HtmlUnit is great")
225-
public void testIncludesAlertTextInUnhandledAlertException() throws Exception {
223+
FF = "Unexpected alert dialog detected. Performed handler \"dismiss\"",
224+
FF_ESR = "Unexpected alert dialog detected. Performed handler \"dismiss\"")
225+
public void includesAlertTextInUnhandledAlertException() throws Exception {
226226
final String html = "<html>\n"
227227
+ "<head>\n"
228228
+ "</head>\n"
@@ -249,10 +249,10 @@ public void testIncludesAlertTextInUnhandledAlertException() throws Exception {
249249
@Test
250250
@Alerts("Unexpected alert found: HtmlUnit is great")
251251
@BuggyWebDriver(DEFAULT = "unexpected alert open: {Alert text : HtmlUnit is great}",
252-
FF = "Dismissed user prompt dialog: HtmlUnit is great",
253-
FF_ESR = "Dismissed user prompt dialog: HtmlUnit is great")
252+
FF = "Unexpected alert dialog detected. Performed handler \"dismiss\"",
253+
FF_ESR = "Unexpected alert dialog detected. Performed handler \"dismiss\"")
254254
@NotYetImplemented
255-
public void testIncludesAlertTextInUnhandledAlertExceptionFromnAsyncScript() throws Exception {
255+
public void includesAlertTextInUnhandledAlertExceptionFromnAsyncScript() throws Exception {
256256
final String html = "<html>\n"
257257
+ "<head>\n"
258258
+ "</head>\n"

src/test/java/org/openqa/selenium/htmlunit/interactions/ClickTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,10 +189,10 @@ public void ctrlClick() throws Exception {
189189
"[object MouseEvent]", "2", "[object PointerEvent]", "0"},
190190
EDGE = {"[object Event]", "undefined", "[object PointerEvent]", "1",
191191
"[object MouseEvent]", "2", "[object PointerEvent]", "0"},
192-
FF = {"[object Event]", "undefined", "[object MouseEvent]", "1",
193-
"[object MouseEvent]", "2", "[object MouseEvent]", "1"},
192+
FF = {"[object Event]", "undefined", "[object PointerEvent]", "1",
193+
"[object MouseEvent]", "2", "[object PointerEvent]", "1"},
194194
FF_ESR = {"[object Event]", "undefined", "[object MouseEvent]", "1",
195-
"[object MouseEvent]", "2", "[object MouseEvent]", "2"})
195+
"[object MouseEvent]", "2", "[object MouseEvent]", "1"})
196196
public void detail() throws Exception {
197197
final String html =
198198
"<html><head><script>\n"

0 commit comments

Comments
 (0)