Skip to content

Commit 0661b06

Browse files
committed
[dotnet] [bidi] Make DisposeAsyncCore protected
1 parent 2e0f84e commit 0661b06

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

dotnet/src/webdriver/BiDi/BiDi.cs

+5-5
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,14 @@ public Task EndAsync(Modules.Session.EndOptions? options = null)
8080
return SessionModule.EndAsync(options);
8181
}
8282

83-
public virtual async ValueTask DisposeAsyncCore()
84-
{
85-
await _broker.DisposeAsync().ConfigureAwait(false);
86-
}
87-
8883
public async ValueTask DisposeAsync()
8984
{
9085
await DisposeAsyncCore();
9186
GC.SuppressFinalize(this);
9287
}
88+
89+
protected virtual async ValueTask DisposeAsyncCore()
90+
{
91+
await _broker.DisposeAsync().ConfigureAwait(false);
92+
}
9393
}

dotnet/src/webdriver/BiDi/Communication/Broker.cs

+7-7
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,13 @@ public async Task UnsubscribeAsync(Modules.Session.Subscription subscription, Ev
302302
}
303303
}
304304

305-
public virtual async ValueTask DisposeAsyncCore()
305+
public async ValueTask DisposeAsync()
306+
{
307+
await DisposeAsyncCore();
308+
GC.SuppressFinalize(this);
309+
}
310+
311+
protected virtual async ValueTask DisposeAsyncCore()
306312
{
307313
_pendingEvents.CompleteAdding();
308314

@@ -315,10 +321,4 @@ public virtual async ValueTask DisposeAsyncCore()
315321

316322
_transport.Dispose();
317323
}
318-
319-
public async ValueTask DisposeAsync()
320-
{
321-
await DisposeAsyncCore();
322-
GC.SuppressFinalize(this);
323-
}
324324
}

0 commit comments

Comments
 (0)