firefoxdriver: don't return window name

juangj · andreastt · commit 0ae8a97991f6 · 2015-03-24T21:52:30.000Z
Never attempt to return the window name from getWindowHandles; only return driver-generated handles. Fixes #351. Signed-off-by: Andreas Tolfsen <ato@mozilla.com>
diff --git a/javascript/firefox-driver/js/nsCommandProcessor.js b/javascript/firefox-driver/js/nsCommandProcessor.js
@@ -600,8 +600,6 @@ nsCommandProcessor.prototype.getWindowHandles = function(response) {
   this.searchWindows_('navigator:browser', function(win) {
     if (win.top && win.top.fxdriver) {
       res.push(win.top.fxdriver.id);
-    } else if (win.content) {
-      res.push(win.content.name);
     }
   });
   response.value = res;

Original file line number	Diff line number	Diff line change
`@@ -600,8 +600,6 @@ nsCommandProcessor.prototype.getWindowHandles = function(response) {`
`600`	`600`	`this.searchWindows_('navigator:browser', function(win) {`
`601`	`601`	`if (win.top && win.top.fxdriver) {`
`602`	`602`	`res.push(win.top.fxdriver.id);`
`603`		`- } else if (win.content) {`
`604`		`- res.push(win.content.name);`
`605`	`603`	`}`
`606`	`604`	`});`
`607`	`605`	`response.value = res;`