python: Closing driver server i/o channels when driver server stopped. Fixes issue 8498 on googlecode

Author: barancev

py/selenium/webdriver/chrome/service.py

@@ -108,6 +108,8 @@ def stop(self):
         #Tell the Server to properly die in case
         try:
             if self.process:
+                self.process.stdout.close()
+                self.process.stderr.close()
                 self.process.kill()
                 self.process.wait()
         except OSError:

py/selenium/webdriver/ie/service.py

@@ -28,7 +28,7 @@ class Service(object):
     def __init__(self, executable_path, port=0, host=None, log_level=None, log_file=None):
         """
         Creates a new instance of the Service
-        
+
         :Args:
          - executable_path : Path to the IEDriver
          - port : Port the service is running on
@@ -48,8 +48,8 @@ def __init__(self, executable_path, port=0, host=None, log_level=None, log_file=
 
     def start(self):
         """
-        Starts the IEDriver Service. 
-        
+        Starts the IEDriver Service.
+
         :Exceptions:
          - WebDriverException : Raised either when it can't start the service
            or when it can't connect to the service
@@ -77,9 +77,9 @@ def start(self):
             time.sleep(1)
             if count == 30:
                  raise WebDriverException("Can not connect to the IEDriver")
-                
+
     def stop(self):
-        """ 
+        """
         Tells the IEDriver to stop and cleans up the process
         """
         #If its dead dont worry
@@ -96,13 +96,15 @@ def stop(self):
         count = 0
         while utils.is_connectable(self.port):
             if count == 30:
-               break 
+               break
             count += 1
             time.sleep(1)
-        
+
         #Tell the Server to properly die in case
         try:
             if self.process:
+                self.process.stdout.close()
+                self.process.stderr.close()
                 self.process.kill()
                 self.process.wait()
         except WindowsError:

py/selenium/webdriver/phantomjs/service.py

@@ -101,6 +101,7 @@ def stop(self):
         #Tell the Server to properly die in case
         try:
             if self.process:
+                self.process.stdin.close()
                 self.process.send_signal(signal.SIGTERM)
                 self.process.wait()
         except OSError: