Skip to content

Commit 4240536

Browse files
committed
fix minor comments and adjust logic improvement
1 parent 4d42101 commit 4240536

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

Diff for: dotnet/src/webdriver/Remote/HttpCommandExecutor.cs

+5-8
Original file line numberDiff line numberDiff line change
@@ -414,22 +414,19 @@ public DiagnosticsHttpHandler(HttpMessageHandler messageHandler)
414414
/// <returns>The http response message content.</returns>
415415
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
416416
{
417-
if (request.Content != null)
418-
{
419-
var requestContent = await request.Content.ReadAsStringAsync().ConfigureAwait(false);
420-
_logger.Trace($">> Body: {requestContent}");
421-
}
422-
423417
var response = await base.SendAsync(request, cancellationToken).ConfigureAwait(false);
424418

425-
if (!response.IsSuccessStatusCode)
419+
if (!response.IsSuccessStatusCode && response.Content != null && request.Content != null)
426420
{
421+
var requestContent = await request.Content.ReadAsStringAsync().ConfigureAwait(false);
427422
var responseContent = await response.Content.ReadAsStringAsync().ConfigureAwait(false);
428-
_logger.Trace($"<< Body: {responseContent}");
423+
424+
_logger.Trace($">> Request Body: {requestContent}\n\n<< Response Body: {responseContent}");
429425
}
430426

431427
return response;
432428
}
429+
433430
}
434431
}
435432
}

0 commit comments

Comments
 (0)