Skip to content

Commit 57c989c

Browse files
authored
[grid] Grid UI could not open session live view (#15132)
* [grid] Grid UI could not open session live view * Bump version 4.28.1 for java and update changelog --------- Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 43c6e35 commit 57c989c

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

Diff for: java/CHANGELOG

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
v4.28.1
2+
======
3+
* [java]: Add Locale.ROOT to avoid port formatting issues for all drivers (#15121)
4+
* [grid]: Grid UI could not open session live view (#15132)
5+
16
v4.28.0
27
======
38
* Add CDP for Chrome 132 and remove 129

Diff for: java/version.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
SE_VERSION = "4.29.0-SNAPSHOT"
1+
SE_VERSION = "4.28.1"
22
TOOLS_JAVA_VERSION = "17"

Diff for: javascript/grid-ui/src/components/LiveView/LiveView.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,13 @@ const LiveView = forwardRef((props, ref) => {
6060
return
6161
}
6262

63-
const newRfb = new RFB(canvas, props.url, {})
63+
const newRfb = new RFB.default(canvas, props.url, {})
6464
newRfb.scaleViewport = props.scaleViewport
6565
newRfb.background = 'rgb(247,248,248)'
6666
newRfb.addEventListener('credentialsrequired', handleCredentials)
6767
newRfb.addEventListener('securityfailure', securityFailed)
6868
newRfb.addEventListener('connect', connectedToServer)
69+
newRfb.addEventListener('disconnect', disconnect)
6970
setRfb(newRfb)
7071
}
7172

0 commit comments

Comments
 (0)