Skip to content

Commit 596070d

Browse files
authored
[bazel + ci]: Stop being selective about which parts of the tree to test (#14373)
We no longer need to do this now that the entire project is built with Bazel.
1 parent 3bad4c7 commit 596070d

File tree

4 files changed

+31
-27
lines changed

4 files changed

+31
-27
lines changed

.skipped-tests

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
-//javascript/atoms:test-chrome
2020
-//javascript/atoms:test-edge
2121
-//javascript/atoms:test-firefox-beta
22+
-//javascript/chrome-driver/...
2223
-//javascript/node/selenium-webdriver:test-bidi-network-test.js-chrome
2324
-//javascript/node/selenium-webdriver:test-builder-test.js-chrome
2425
-//javascript/node/selenium-webdriver:test-builder-test.js-firefox
@@ -54,3 +55,4 @@
5455
-//rb/spec/integration/selenium/webdriver:element-chrome
5556
-//rb/spec/integration/selenium/webdriver:element-chrome-bidi
5657
-//rb/spec/integration/selenium/webdriver:element-chrome-remote
58+
-//rust/tests/...

rust/BUILD.bazel

+2-20
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@crates//:defs.bzl", "all_crate_deps")
2-
load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_test", "rust_test_suite", "rustfmt_config")
2+
load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_test", "rustfmt_config")
33

44
rustfmt_config(
55
name = "enable-rustfmt",
@@ -92,6 +92,7 @@ rust_library(
9292
exclude = ["main.rs"],
9393
),
9494
edition = "2021",
95+
visibility = ["//rust:__subpackages__"],
9596
deps = all_crate_deps(normal = True),
9697
)
9798

@@ -117,22 +118,3 @@ rust_test(
117118
edition = "2021",
118119
tags = ["no-sandbox"],
119120
)
120-
121-
rust_test_suite(
122-
name = "integration",
123-
size = "small",
124-
srcs = glob(["tests/**/*_tests.rs"]),
125-
data = [
126-
"tests/common.rs",
127-
":selenium-manager",
128-
],
129-
edition = "2021",
130-
tags = [
131-
"no-sandbox",
132-
"requires-network",
133-
],
134-
deps = [":selenium_manager"] + all_crate_deps(
135-
normal = True,
136-
normal_dev = True,
137-
),
138-
)

rust/tests/BUILD.bazel

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
load("@crates//:defs.bzl", "all_crate_deps")
2+
load("//rust:defs.bzl", "rust_test_suite", "rustfmt_config")
3+
4+
rustfmt_config(
5+
name = "enable-rustfmt",
6+
)
7+
8+
rust_test_suite(
9+
name = "integration",
10+
size = "small",
11+
srcs = glob(["**/*_tests.rs"]),
12+
data = [
13+
"common.rs",
14+
"//rust:selenium-manager",
15+
],
16+
edition = "2021",
17+
tags = [
18+
"no-sandbox",
19+
"requires-network",
20+
],
21+
deps = ["//rust:selenium_manager"] + all_crate_deps(
22+
package_name = "rust",
23+
normal = True,
24+
normal_dev = True,
25+
),
26+
)

scripts/github-actions/ci-build.sh

+1-7
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,7 @@ set -x
1010
bazel test --config=remote-ci --build_tests_only \
1111
--test_tag_filters=-exclusive-if-local,-skip-remote \
1212
--keep_going --flaky_test_attempts=2 \
13-
//dotnet/... \
14-
//java/... \
15-
//javascript/atoms/... \
16-
//javascript/node/selenium-webdriver/... \
17-
//javascript/webdriver/... \
18-
//py/... \
19-
//rb/spec/... -- $(cat .skipped-tests | tr '\n' ' ')
13+
//... -- $(cat .skipped-tests | tr '\n' ' ')
2014

2115
# Build the packages we want to ship to users
2216
bazel build --config=remote-ci \

0 commit comments

Comments
 (0)