Skip to content

Commit 5c08747

Browse files
committed
[bidi] [java] Fix the adding and the removing listener
1 parent 48fd956 commit 5c08747

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

java/src/org/openqa/selenium/bidi/Connection.java

+1-14
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,7 @@ public <X> long addListener(Event<X> event, Consumer<X> handler) {
189189
Lock lock = callbacksLock.writeLock();
190190
lock.lock();
191191
try {
192-
eventCallbacks.computeIfAbsent(
193-
event,
194-
key -> {
195-
HashMap<Long, Consumer<?>> map = new HashMap<>();
196-
map.put(id, handler);
197-
return map;
198-
});
192+
eventCallbacks.computeIfAbsent(event, key -> new HashMap<>()).put(id, handler);
199193
} finally {
200194
lock.unlock();
201195
}
@@ -217,13 +211,6 @@ public void removeListener(long id) {
217211
lock.lock();
218212
try {
219213
eventCallbacks.forEach((k, v) -> v.remove(id));
220-
eventCallbacks.forEach(
221-
(k, v) -> {
222-
v.remove(id);
223-
if (v.isEmpty()) {
224-
eventCallbacks.remove(k);
225-
}
226-
});
227214
} finally {
228215
lock.unlock();
229216
}

0 commit comments

Comments
 (0)