|
276 | 276 |
|
277 | 277 | action(radioButtons[0]);
|
278 | 278 |
|
279 |
| - assertChanges(0); |
| 279 | + // Chromium 44 seems to have a regression here: |
| 280 | + // https://code.google.com/p/chromium/issues/detail?id=500084 |
| 281 | + if (!goog.userAgent.product.CHROME || !bot.userAgent.isProductVersion(44)) { |
| 282 | + assertChanges(0); |
| 283 | + } |
280 | 284 | assertTrue(bot.dom.isSelected(radioButtons[0]));
|
281 | 285 | }
|
282 | 286 |
|
|
361 | 365 |
|
362 | 366 | action(elem);
|
363 | 367 |
|
364 |
| - // WebKit and IE9 standards mode fire change events when the |
| 368 | + // WebKit (except Chromium 44+) and IE9 standards mode fire change events when the |
365 | 369 | // checkbox isn't toggled.
|
366 |
| - assertChanges( |
367 |
| - goog.userAgent.WEBKIT || bot.userAgent.IE_DOC_9 ? 1 : 0); |
| 370 | + // TODO: Check if Chromium behavior changes after this issue is resolved: |
| 371 | + // https://code.google.com/p/chromium/issues/detail?id=500084 |
| 372 | + if (bot.userAgent.IE_DOC_9 || |
| 373 | + (goog.userAgent.WEBKIT && |
| 374 | + !(goog.userAgent.product.CHROME && bot.userAgent.isProductVersion(44)))) { |
| 375 | + assertChanges(1); |
| 376 | + } else { |
| 377 | + assertChanges(0); |
| 378 | + } |
368 | 379 | assertFalse(bot.dom.isSelected(elem));
|
369 | 380 | }
|
370 | 381 |
|
|
387 | 398 |
|
388 | 399 | action(elem);
|
389 | 400 |
|
390 |
| - // Chrome < 39 and WebKit select a radio button even when the handler |
391 |
| - // prevents the default; IE does not. |
392 |
| - if ((goog.userAgent.product.CHROME && |
393 |
| - !bot.userAgent.isProductVersion(39)) || |
394 |
| - (goog.userAgent.WEBKIT && !goog.userAgent.product.CHROME)) { |
| 401 | + // WebKit selects a radio button even when the handler prevents the default; others do not. |
| 402 | + if (goog.userAgent.WEBKIT && !goog.userAgent.product.CHROME) { |
395 | 403 | assertChanges(1);
|
396 | 404 | assertTrue(bot.dom.isSelected(elem));
|
397 | 405 | } else {
|
398 |
| - // IE9 standards mode and Chrome still fire the change event. |
399 |
| - if (bot.userAgent.IE_DOC_9 || goog.userAgent.product.CHROME) { |
| 406 | + // IE9 standards mode, Chromium 43 and earlier versions still fire the change event. |
| 407 | + // TODO: Check if Chromium behavior changes after this issue is resolved: |
| 408 | + // https://code.google.com/p/chromium/issues/detail?id=500084 |
| 409 | + if (bot.userAgent.IE_DOC_9 || |
| 410 | + goog.userAgent.product.CHROME && !bot.userAgent.isProductVersion(44)) { |
400 | 411 | assertChanges(1);
|
401 | 412 | } else {
|
402 | 413 | assertChanges(0);
|
|
0 commit comments